Change in osmocom-bb[master]: trxcon: fix potential buffer overflow in l1ctl_proc_est_req_h1()

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18542 )

Change subject: trxcon: fix potential buffer overflow in l1ctl_proc_est_req_h1()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmocom-bb/+/18542/1/src/host/trxcon/l1ctl.c 
File src/host/trxcon/l1ctl.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/18542/1/src/host/trxcon/l1ctl.c@609 
PS1, Line 609: 	} else if (h->n > 64) {
With 'else' it (visually) looks more like a set of related checks, IMHO. I believe there is no difference in the generated machine code...

> You could use "> ARRAY_SIZE(ma)"

ACK.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18542
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I10f03ca66412a4a7094b0f4a7319411d5d5818ef
Gerrit-Change-Number: 18542
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 28 May 2020 11:57:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/f35d1dce/attachment.htm>