Change in osmo-ci[master]: scripts: source common.sh before cd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu May 28 10:14:58 UTC 2020


osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18480 )

Change subject: scripts: source common.sh before cd
......................................................................

scripts: source common.sh before cd

common.sh tries to set OSMO_CI_DIR now; however this does not work when
common.sh was sourced with ". ./common.sh":

	realpath: scripts/..: No such file or directory

Fixes: 7cb8e2d0 ("OBS: add debian10 specific patch for limesuite")
Related: https://jenkins.osmocom.org/jenkins/job/Osmocom-build-tags-against-master/455/console
Change-Id: Ib326eb0fa769528398335c9cf06dc9c9576c882e
---
M scripts/osmocom-build-old-tags-against-master.sh
M scripts/osmocom-release-tarballs.sh
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Verified



diff --git a/scripts/osmocom-build-old-tags-against-master.sh b/scripts/osmocom-build-old-tags-against-master.sh
index 58a0009..e7e6bff 100755
--- a/scripts/osmocom-build-old-tags-against-master.sh
+++ b/scripts/osmocom-build-old-tags-against-master.sh
@@ -7,8 +7,8 @@
 # Latest result:
 # https://jenkins.osmocom.org/jenkins/job/Osmocom-build-tags-against-master/lastBuild/console
 
+. "$(dirname "$0")/common.sh"
 cd "$(dirname "$0")"
-. ./common.sh
 ERROR_LOGS=""
 PARALLEL_MAKE="${PARALLEL_MAKE:--j5}"
 
diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh
index b9d21c3..3f8b920 100755
--- a/scripts/osmocom-release-tarballs.sh
+++ b/scripts/osmocom-release-tarballs.sh
@@ -7,8 +7,8 @@
 # * KEEP_TEMP: do not delete cloned repositories (use for development)
 # * PARALLEL_MAKE: -jN argument for make (default: -j5).
 
+. "$(dirname "$0")/common.sh"
 cd "$(dirname "$0")"
-. ./common.sh
 PARALLEL_MAKE="${PARALLEL_MAKE:--j5}"
 OUTPUT="$(cd ..; pwd)/_release_tarballs"
 TEMP="$(cd ..; pwd)/_temp"

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18480
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib326eb0fa769528398335c9cf06dc9c9576c882e
Gerrit-Change-Number: 18480
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/641b253a/attachment.htm>


More information about the gerrit-log mailing list