Change in osmo-ttcn3-hacks[master]: library/L1CTL_Types: fix definition of L1ctlH1 (hopping parameters)

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18527 )


Change subject: library/L1CTL_Types: fix definition of L1ctlH1 (hopping parameters)
......................................................................

library/L1CTL_Types: fix definition of L1ctlH1 (hopping parameters)

Change-Id: I87555de751e6e4af6ac5fe308c3e77fa15c8bb16
Related: OS#4546
---
M library/L1CTL_Types.ttcn
1 file changed, 13 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/18527/1

diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn
index fc58652..83892fd 100644
--- a/library/L1CTL_Types.ttcn
+++ b/library/L1CTL_Types.ttcn
@@ -290,13 +290,23 @@
 		octetstring	l2_payload
 	} with { variant "" };
 
+	type record length(0..64) of Arfcn L1ctlMA;
 	type record L1ctlH1 {
 		uint8_t		hsn,
 		uint8_t		maio,
 		uint8_t		n,
-		OCT1		padding,
-		bitstring	ma length(64)
-	} with { variant "" };
+		OCT1		spare,
+		L1ctlMA		ma,
+		octetstring	padding
+	} with {
+		variant (n) "LENGTHTO(ma)"
+		variant (n) "UNIT(elements)"
+		/* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562849.
+		 * TL;DR The reference point of the PADDING attribute is the beginning
+		 * of the message, not the beginning of the type/field it's applied on.
+		 * Therefore we cannot use it here, and have to add padding manually.
+		 * variant (ma) "PADDING(128)" */
+	};
 
 	type record L1ctlDmEstReq {
 		GsmTsc		tsc,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87555de751e6e4af6ac5fe308c3e77fa15c8bb16
Gerrit-Change-Number: 18527
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200527/4bc3cae3/attachment.htm>