Change in libosmocore[master]: add osmo_mobile_identity API

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18507 )

Change subject: add osmo_mobile_identity API
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18507/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/18507/1//COMMIT_MSG@27 
PS1, Line 27: gsm48_mi_to_string() decodes a TMSI as a decimal number. These days we use
            :   hexadecimal TMSI everywhere.
we could simply change the implementation to generate a hex string instead of a decimal number in the output string.


https://gerrit.osmocom.org/c/libosmocore/+/18507/1//COMMIT_MSG@32 
PS1, Line 32: osmo-bsc's extract_sub() first uses gsm48_mi_to_string() which encodes the
            :   raw uint32_t TMSI to a string, and then calls strtoul() via
            :   tmsi_from_string() to code those back to a raw uint32_t.
that's of course ugly and should be changed.


https://gerrit.osmocom.org/c/libosmocore/+/18507/1//COMMIT_MSG@44 
PS1, Line 44: which
            : might subsequently replace older code dup.
I think if we don'd to this right now after merging this code, the duplication will stay.  So if we agree this new decoder is what we want, I would like to request conversion of the existing users (I guess directly the users/applications, while marking the old library code as DEPRECATED?)



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18507
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f969e739654c1e8c387aedeeba5cce07fe2307
Gerrit-Change-Number: 18507
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 27 May 2020 08:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200527/14b61345/attachment.htm>