Change in libosmocore[master]: api doc: clarify 'returns' of gsm48_mi_to_string()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue May 26 20:29:09 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18476 )

Change subject: api doc: clarify 'returns' of gsm48_mi_to_string()
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

combining +1 x2

https://gerrit.osmocom.org/c/libosmocore/+/18476/1/src/gsm/gsm48.c 
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/c/libosmocore/+/18476/1/src/gsm/gsm48.c@740 
PS1, Line 740:  *  \returns Return <= 0 on error, > 0 on success.
> Probably worth explaning what the meaning of the value is when >0.
>0 rc are FUBAR, and that is the entire rest of this 'returns' explanation; don't tell me you missed the "WARNING" text we already had before this patch...



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18476
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I81646ff8284061a60c208bd8f9233f66c3e410f8
Gerrit-Change-Number: 18476
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 26 May 2020 20:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200526/b86df5d3/attachment.htm>


More information about the gerrit-log mailing list