Change in libosmo-abis[master]: log: Don't log an ERROR on forwarding message to a closed SCCP link.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Mon May 25 21:16:53 UTC 2020


ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18439 )

Change subject: log: Don't log an ERROR on forwarding message to a closed SCCP link.
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> I really think this is the wrong location to fix this problem.
> 
> The code receiving an IPA message (here) has nothing to do with the BSC core functionality, and it shouldn't know anything about MSCs or SCCP.
> 
> IMHO, the "bug" is in the BSC code.  It should neve return an error (negative result to sign_link callback function) in a non-error situation.

Makes sense.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18439
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7af0da70185a86e10737d93001fb9352dbd233ec
Gerrit-Change-Number: 18439
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 May 2020 21:16:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200525/689844d0/attachment.htm>


More information about the gerrit-log mailing list