This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18374 ) Change subject: manuals: generate vty reference xml at build time ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am File doc/manuals/Makefile.am: https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am@24 PS2, Line 24: $(top_builddir)/src/osmo-bsc/osmo-bsc > Then afaiu Make should already handle dependencies correctly and there's no need for this patch? Am not sure I get what you're saying, pespin. The point is to build the bsc_vty_reference.xml, for that we need osmo-bsc. How does that not need this patch? Make's multi-dir support isn't great. Depending on osmo-bsc here is more about re-generating the XML file when the binary has changed (and not every time). We would indeed cause a 'make -C src/osmo-bsc osmo-bsc' but I fear that that fires a separate make process. BTW, this is not a situation specific to this patch, this same thing happens for all of our binaries (e.g. unit tests) requiring lib files from elsewhere in the source tree. So far it seems to work out ok in our builds by naming the subdir that builds the dependencies first. I think this is one reason why so many build systems other than 'make' were written. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5dc872149154e1a949bb6a2b9bbc1461e0fc51f6 Gerrit-Change-Number: 18374 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 25 May 2020 20:34:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200525/b34f106e/attachment.htm>