Change in osmo-ttcn3-hacks[master]: library/RSL_Emulation: server mode: handle multiple transceivers

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18465 )

Change subject: library/RSL_Emulation: server mode: handle multiple transceivers
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18465/1/library/RSL_Emulation.ttcn 
File library/RSL_Emulation.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18465/1/library/RSL_Emulation.ttcn@335 
PS1, Line 335: /* Find IPAC_IDTAG_UNITID in the IPA IDENTITY RESPONSE */
             : 	for (var integer i := 0; i < sizeof(id_resp); i := i + 1) {
             : 		if (id_resp[i].tag == IPAC_IDTAG_UNITID) {
             : 			unit_id := oct2char(id_resp[i].data);
             : 			break;
             : 		}
             : 
             : 		/* If this is the last element, nothing is found */
             : 		if (i + 1 == sizeof(id_resp)) {
             : 			testcase.stop("IPA IDENTITY RESPONSE contains no unit-id");
             : 		}
             : 	}
could probably be generalized into a function that finds/extracts any TLV/IE. Similar to what we have with f_rsl_find_ie()?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18465/1/library/RSL_Emulation.ttcn@353 
PS1, Line 353: /* Parse transceiver number (site/bts/trx) */
             : 	unit_id := regexp(unit_id, unit_id_fmt, 2);
             : 	trx_nr  := str2int(unit_id);
probably better to introduce an abstract type that represents the tuple (site_id, bts_id, trx_id)?  In that case you could also actually use declarative parsing like our MGCP_types?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18465
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86afb55ecc6703ce7a229aaa626223f9331a4778
Gerrit-Change-Number: 18465
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 25 May 2020 16:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200525/65946ae6/attachment.htm>