Change in osmo-ci[master]: OBS: add debian10 specific patch for limesuite

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon May 25 11:36:25 UTC 2020


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/18394 )

Change subject: OBS: add debian10 specific patch for limesuite
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ci/+/18394/2/scripts/common-obs.sh 
File scripts/common-obs.sh:

https://gerrit.osmocom.org/c/osmo-ci/+/18394/2/scripts/common-obs.sh@134 
PS2, Line 134: 	if [ -f "$ret" ]; then
> Hmm just thought we may be careful with -f here, because if patch is a symlink it will not work afai […]
This should be fine, the -f check would only fail if it was a symlink and the destination was some invalid path. But then we could not apply the patch either. Even if this was a problem (maybe relative paths involved in the symlink), we would probably quickly discover that the patch was not found as patch would fail later. Having a patch in both osmo-ci.git and the project specific repository doesn't really make sense.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/18394
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8dfb60e999bf9f61e6cd11983dba033a4c6107ad
Gerrit-Change-Number: 18394
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 May 2020 11:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200525/efa818bb/attachment.htm>


More information about the gerrit-log mailing list