Change in osmo-pcu[master]: encoding: cosmetic: use RLC_MODE_ACKNOWLEDGED where possible

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18434 )

Change subject: encoding: cosmetic: use RLC_MODE_ACKNOWLEDGED where possible
......................................................................

encoding: cosmetic: use RLC_MODE_ACKNOWLEDGED where possible

Change-Id: Ic69d120f622f512f05016596bfdd4a89b96e3e3b
---
M src/encoding.cpp
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved



diff --git a/src/encoding.cpp b/src/encoding.cpp
index 1805645..cb89b01 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -197,7 +197,8 @@
 	CHECK(rc);
 
 	/* RLC acknowledged mode */
-	SET_0(dest); /* RLC_MODE */
+	rc = bitvec_set_bit(dest, (bit_value) RLC_MODE_ACKNOWLEDGED);
+	CHECK(rc);
 
 	rc = write_alpha_gamma(dest, alpha, gamma);
 	CHECK(rc);
@@ -668,7 +669,7 @@
 	}
 
 	block->u.Packet_Downlink_Assignment.MAC_MODE            = 0x0;          // Dynamic Allocation
-	block->u.Packet_Downlink_Assignment.RLC_MODE            = 0x0;          // RLC acknowledged mode
+	block->u.Packet_Downlink_Assignment.RLC_MODE            = RLC_MODE_ACKNOWLEDGED;
 	block->u.Packet_Downlink_Assignment.CONTROL_ACK         = tbf->was_releasing; // NW establishes no new DL TBF for the MS with running timer T3192
 	block->u.Packet_Downlink_Assignment.TIMESLOT_ALLOCATION = 0;   // timeslot(s)
 	for (tn = 0; tn < 8; tn++) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18434
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic69d120f622f512f05016596bfdd4a89b96e3e3b
Gerrit-Change-Number: 18434
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200525/42e7d097/attachment.htm>