Change in osmo-bts[master]: Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri May 22 12:09:16 UTC 2020


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18398 )

Change subject: Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/18398/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/18398/1//COMMIT_MSG@7 
PS1, Line 7: Makefile.am: EXTRA_DIST: debian, contrib/*.spec.in
> all the commits lines look crypted. No verb at all, only a list of stuff.
You're right, the "add" is missing:

Makefile.am: EXTRA_DIST: add debian, contrib/*.spec.in

Still, I would argue it's clear from the context. Can I leave it as-is, considering that I'd need to change all other commits too otherwise?


https://gerrit.osmocom.org/c/osmo-bts/+/18398/1/Makefile.am 
File Makefile.am:

https://gerrit.osmocom.org/c/osmo-bts/+/18398/1/Makefile.am@7 
PS1, Line 7: EXTRA_DIST = \
Yes.

> Add debian dir, .spec.in

This is the main change, the rest is just cosmetics while I'm at it. I thought it would be obvious what's going on here. Is this acceptable, or should I just add the two files and keep the rest as-is?

(If possible I'd like to avoid changing Makefile.am in lots of repositories though, this eats up quite some time.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18398
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia08afb32b228d0a2380190e358364e07b20ce0f3
Gerrit-Change-Number: 18398
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 22 May 2020 12:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200522/3c71e685/attachment.htm>


More information about the gerrit-log mailing list