Change in osmo-pcu[master]: gsmtap: Set signal level and SNR fields

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue May 19 19:55:59 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18365 )

Change subject: gsmtap: Set signal level and SNR fields
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/18365/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/18365/2//COMMIT_MSG@10 
PS2, Line 10: nothing
maybe put a clear comment about this in the code right where we do this?  Something like "GSMTAP needs the SNR here, but we only have C/I. Those are not the same, but there is no known way to convert them, let's pass C/I instead of nothing"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibe9502d42c8bd1b984069e7fd805dde87ecbab0c
Gerrit-Change-Number: 18365
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 19 May 2020 19:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/4abc66ee/attachment.htm>


More information about the gerrit-log mailing list