Change in libosmocore[master]: gsmtap_makemsg_ex: NULL for unknown chan_type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue May 19 13:58:33 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18361 )

Change subject: gsmtap_makemsg_ex: NULL for unknown chan_type
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/18361/1/src/gsmtap_util.c 
File src/gsmtap_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/18361/1/src/gsmtap_util.c@186 
PS1, Line 186: 	if (chan_type == GSMTAP_CHANNEL_UNKNOWN)
> Why not generating a message for that channel type? I wanna see that in pcap files and see something […]
I think returning NULL indicates to the caller that something is wrong, and it should be handled there.
I just hope that all callers check for the return value.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib4147a33a75c3cf425c30da8b0678c7fba8a371d
Gerrit-Change-Number: 18361
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 May 2020 13:58:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/d5a5216d/attachment.htm>


More information about the gerrit-log mailing list