This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18232 ) Change subject: bssap: Handle BSSMAP CONFUSION message. ...................................................................... Patch Set 10: Code-Review-1 (4 comments) (-1 for error log verbosity) https://gerrit.osmocom.org/c/osmo-bsc/+/18232/10//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/18232/10//COMMIT_MSG@13 PS10, Line 13: Requires: libosmocore.git Change-Id If8afd2d096fb66c6c2f255a08fc1129de3d09cec we're commonly using 'Depends:' instead. Depends: If8afd2d096fb66c6c2f255a08fc1129de3d09cec (libosmocore) https://gerrit.osmocom.org/c/osmo-bsc/+/18232/10//COMMIT_MSG@14 PS10, Line 14: (and we usually don't have a blank line here) https://gerrit.osmocom.org/c/osmo-bsc/+/18232/10/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18232/10/src/osmo-bsc/osmo_bsc_bssap.c@1027 PS10, Line 1027: "Received Confusion message," please state "BSSMAP" as in "BSSMAP Confusion message", otherwise it is confusing. ... or does the FSM id already say "BSSMAP"? Anyway, it could still be confused for some internal event, let's rather name BSSMAP. Same below. https://gerrit.osmocom.org/c/osmo-bsc/+/18232/10/src/osmo-bsc/osmo_bsc_bssap.c@1064 PS10, Line 1064: osmo_hexdump(diag->msg, diag_len-2)); Please don't spam the error log like this, I'd much prefer combining these several bits of information on *one* log line. Especially the ERROR log is very strong in punching through silent logging configuration, so this should be as unobtrusive as possible (while still reflecting the interesting information). I'm thinking like Rx BSSMAP Confusion: class 0x23 cause 0x42 msg <name> octet 23 (string) bit 3 (string) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib4cd94f185f751b2384842222678ff671ac413c4 Gerrit-Change-Number: 18232 Gerrit-PatchSet: 10 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 18 May 2020 17:13:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200518/3e50ad82/attachment.htm>