This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18334 )
Change subject: stats: Correctly count lchans under BORKEN/NOT_INITIALIZED TS.
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/c/osmo-bsc/+/18334/4/src/osmo-bsc/chan_alloc.c
File src/osmo-bsc/chan_alloc.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/18334/4/src/osmo-bsc/chan_alloc.c@93
PS4, Line 93: if (!ts_is_usable(ts)) {
This function also triggers on disconnected TRX or timeslots still in the UNINITIALIZED state.
I'm not sure this should count as used. If you specifically want to target BORKEN, maybe rather test for ts->fi->state?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18334
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic3dbc6b176d5dcff7ed2589bb875abf93e9f7ab0
Gerrit-Change-Number: 18334
Gerrit-PatchSet: 4
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 May 2020 17:00:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200518/481a5d15/attachment.htm>