Change in osmo-ttcn3-hacks[master]: Move all GPRS helper function to its own file and component

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon May 18 15:42:01 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333 )

Change subject: Move all GPRS helper function to its own file and component
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn@168 
PS2, Line 168: f_pcuif_rx_imm_ass
> compilation fails if I leave "private", I tested it.
you can also use 'friend'. it depends a bit if you think it is a public function for everyone to use,or if it is more some internal function with 1-2 callers (also in the future) and hence the private/friend mechanism might be better in terms of encapsulation.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieae27d6e707f79ec2145864ef5cd67ddbbec9314
Gerrit-Change-Number: 18333
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 May 2020 15:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200518/b77b25b1/attachment.htm>


More information about the gerrit-log mailing list