Change in osmocom-bb[master]: trx_toolkit/transceiver.py: add frequency hopping support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sun May 17 16:29:46 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18262 )

Change subject: trx_toolkit/transceiver.py: add frequency hopping support
......................................................................


Patch Set 3: Code-Review+1

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > I still think moving the freq list to be separated by command would allow you to drop that "variable" arg part.
> 
> I don't see much benefit from that, sorry. Right now the CTRLInterface splits a command into a list for us, while with comma we would have to do that ourselves in the 'SETFH' handling code. I could do it that way, but none of the existing commands using comma to separate arguments, so let's make the new (not really new, but still) command consistent.

Well the benefit is you don't need to make the general protocol more complex by adding commands with variable parameter length. You say "but none of the existing commands using comma to separate arguments", but that's from the point of view that from protocol point of view each freq is an argument, while I'm keeping the general protocol easier by saying that there's 1 argument consisting of a comma limited list of frequencies.
So having given my opinion, do what you prefer, I'm not going to block it.


-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18262
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I587e4f5da67c7b7f28e010ed46b24622c31a3fdd
Gerrit-Change-Number: 18262
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 17 May 2020 16:29:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200517/c71d2819/attachment.htm>


More information about the gerrit-log mailing list