This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18267 ) Change subject: virtual/scheduler: mgsb_free/log unknown GSMTAP chan ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18267/2/src/osmo-bts-virtual/scheduler_virtbts.c File src/osmo-bts-virtual/scheduler_virtbts.c: https://gerrit.osmocom.org/c/osmo-bts/+/18267/2/src/osmo-bts-virtual/scheduler_virtbts.c@82 PS2, Line 82: LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "RSL ctype 0x%02x is unknown in GSMTAP?\n", rsl_chantype); ctype -> channel type Why avoiding handling it in gsmtap_makemsg? better handle this case there so all types are handled, and return NULL. https://gerrit.osmocom.org/c/osmo-bts/+/18267/2/src/osmo-bts-virtual/scheduler_virtbts.c@83 PS2, Line 83: msgb_free(msg); what about goto the end of function? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic22ab71e520ab44429a93724250d349d16250801 Gerrit-Change-Number: 18267 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 15 May 2020 11:16:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200515/7db46cba/attachment.htm>