Change in osmo-bts[master]: osmo-bts-virtual/scheduler: log unknown GSMTAP chan

[osmith]

Hello laforge,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/osmo-bts/+/18267

to review the following change.


Change subject: osmo-bts-virtual/scheduler: log unknown GSMTAP chan
......................................................................

osmo-bts-virtual/scheduler: log unknown GSMTAP chan

Related: SYS#4822
Change-Id: Ic22ab71e520ab44429a93724250d349d16250801
---
M src/osmo-bts-virtual/scheduler_virtbts.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/67/18267/1

diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c
index a60c9e0..3a1431a 100644
--- a/src/osmo-bts-virtual/scheduler_virtbts.c
+++ b/src/osmo-bts-virtual/scheduler_virtbts.c
@@ -78,6 +78,12 @@
 	else
 		gsmtap_chantype = chantype_rsl2gsmtap2(rsl_chantype, chdesc->link_id, is_voice_frame); /* the logical channel type */
 
+	if (gsmtap_chantype == GSMTAP_CHANNEL_UNKNOWN) {
+		LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "RSL ctype 0x%02x is unknown in GSMTAP?\n", rsl_chantype);
+		msgb_free(msg);
+		return;
+	}
+
 #if MODULO_HYPERFRAME
 	/* Restart fn after every superframe (26 * 51 frames) to simulate hyperframe overflow each 6 seconds. */
 	fn %= 26 * 51;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic22ab71e520ab44429a93724250d349d16250801
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200515/f9e87701/attachment.htm>