Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 )

Change subject: pcu: use correct RA type to properly test 2phase access
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/1/pcu/PCU_Tests.ttcn@253 
PS1, Line 253: if (ischosen(dl_block.ctrl.payload.u.ul_assignment)) {
             : 			if (ischosen(dl_block.ctrl.payload.u.ul_assignment)) {
             : 				if (dl_block.ctrl.payload.u.ul_assignment.is_egprs == '0'B) {
             : 					if (ispresent(dl_block.ctrl.payload.u.ul_assignment.gprs.dyn_block_alloc)) {
             : 						if (dl_block.ctrl.payload.u.ul_assignment.gprs.dyn_block_alloc.ul_tfi_ass_present == '1'B) {
This code is very un-TTCN-ic, i.e. lots of imperative programming like one would do in C, not using the power of templates.  I would assume you could simply have a single match instruction against a respective template as opposd to 5 nested if statements.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If636a4898dfa175fdbd6baf04f7f2c955a9c525d
Gerrit-Change-Number: 18239
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 13 May 2020 16:38:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/cb91b800/attachment.htm>