This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18224 ) Change subject: Drop unneeded arg 'ta' in tbf_alloc_ul() ...................................................................... Patch Set 1: > Patch Set 1: > > Requiring a ta argument can be a good way to make sure callers never forget to set the ta. > For sched_ul_ass_or_rej(), can there ever be a situation where ta was forgotten to set in the ms? IIUC this isn't a functional change. API design wise I tend to prefer the "safer" API that ensures ta is never omitted...? > > I'm not sure why you spent time to write this patch, but to not drag out a bikeshed: if you insist that this must happen, and if you are certain that ta is never forgotten, consider this a +1 from me. If you're unsure then why not just leave this API as it is... The data structure architecture in osmo-pcu is totally fucked up, with classes totally entangled one with another, and these patches clearly show what I'm saying. I'm trying to split stuff consistently so we can finally make some sense out of this code. It makes no sense to pass a TA value (even invalid one) to a TBF function which then sets that MS attribute to the MS object. If the TA is forgotten to be set at any time, it contains the same INVALID default value, so there's no change. So just to be really clear here: I don't think I'm losing my time, and I think all these patches are needed to be able to finally have some code which we can extend and understand properly. Be sure that a lot more of these patches will come over time. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iebb9c57f458690e045ddc45c800209ad8cf621e0 Gerrit-Change-Number: 18224 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Wed, 13 May 2020 13:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/0464608c/attachment.htm>