This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18233 ) Change subject: osmo_bsc_bssap: check for conn early ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18233/1/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18233/1/src/osmo-bsc/osmo_bsc_bssap.c@1220 PS1, Line 1220: int bsc_handle_dt(struct gsm_subscriber_connection *conn, Only call path of this function is: sccp_sap_up handle_data_from_msc bsc_handle_dt and all calls to handle_data_from_msc() in sccp_sap_up are already guarded by an "if (conn)" condition. So what's the point of this patch? I don't really understand. Let's try to fix the root cause instead of guarding against null pointers everywhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib7bdfa03ee1d186a94720c65dd72a594de21e783 Gerrit-Change-Number: 18233 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 13 May 2020 11:45:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/08336264/attachment.htm>