Change in osmo-bts[master]: measurement: expect at least 1 SUB frame for AMR

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17929 )

Change subject: measurement: expect at least 1 SUB frame for AMR
......................................................................


Patch Set 6:

(3 comments)

(forcing gerrit to send stuck review comments)

https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c 
File src/common/measurement.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c@623 
PS1, Line 623: 			 * negotiated in AMD, so we can not know if and how many
> AMD? you mean AMR
Done


https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c@627 
PS1, Line 627: 				    num_meas_sub_expect - num_meas_sub) {
> better keep this in one line, it's more readable.
Done


https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c@665 
PS1, Line 665: 	if (lchan->tch_mode != GSM48_CMODE_SPEECH_AMR) {
> Can we move all these checks together with the ones above in line 643 please?
(I am sorry, gerrit did not send this for some reason in the previous patchset)

I have checked this. I don't think that this is a good idea. What I wanted to express in the log here is something like this:

1. Thats what we received ...
2. Thats what we have replaced ...
3. Error! Looks like we couldn't make it fix.

Unfortunately 2 is inbetween and it makes less sense if I move it to the outside. Just add another comment if you still want to have that changed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fd91b576ff7274caa6d4356bcd7a4fa4311219d
Gerrit-Change-Number: 17929
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 May 2020 10:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/951ed199/attachment.htm>