Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_dl_tbf()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue May 12 16:14:43 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18134 )

Change subject: Expect ms object to exist before calling tbf_alloc_dl_tbf()
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp 
File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp@1055 
PS1, Line 1055: 	int rc;
Makes sense to add OSMO_ASSERT(ms != NULL) here, like you did in the previous change.


https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp@1057 
PS1, Line 1057: ms->egprs_ms_class() == 0
So if we're in 'EGPRS only' mode, and both egprs_ms_class and ms_class == 0, then a phone gets accepted just fine? Just trying to understand the logic behind this, not related to this change.


https://gerrit.osmocom.org/c/osmo-pcu/+/18134/1/src/tbf.cpp@1063 
PS1, Line 1063: ms->set_egprs_ms_class(1);
Wow, unrelated question: why do we overwrite the MS class here? o_O



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18134
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I87f6cdf8288a688466020bda0874e68b57aa71c4
Gerrit-Change-Number: 18134
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 May 2020 16:14:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200512/cc9f74cd/attachment.htm>


More information about the gerrit-log mailing list