Change in osmo-pcu[master]: Expect ms object to exist before calling tbf_alloc_ul_tbf()

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18133 )

Change subject: Expect ms object to exist before calling tbf_alloc_ul_tbf()
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

I am wondering if it's possible to avoid these formal (dummy) MS allocations and make it legal for a TBF to exist without being associated to particular MS instance until it's know to whom it belongs to.

https://gerrit.osmocom.org/c/osmo-pcu/+/18133/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18133/1/src/pdch.cpp@a563 
PS1, Line 563: if (ms) {
I would keep this 'if', and rather allocate the MS in the 'else' branch or so. It does not make sense to call ms->ul_tbf() or ms->dl_tbf() if the MS instance was just allocated...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18133
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I010aa5877902816ae246e09ad5ad87946f96855c
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 12 May 2020 16:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200512/7ad1f577/attachment.htm>