Change in libosmocore[master]: exec: osmo_system_nowait2: initalize *pw pointer with NULL

[dexter]

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17884 )

Change subject: exec: osmo_system_nowait2: initalize *pw pointer with NULL
......................................................................

exec: osmo_system_nowait2: initalize *pw pointer with NULL

The pointer *pw is only populated when the the parameter *user is given,
otherwise it remains uninitalized while it is used later when the
previleges are being dropped.

Change-Id: Idec7041e9ea17a252aefbf6fa90091ae17fd4fcd
Fixes: CID#209895
---
M src/exec.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/exec.c b/src/exec.c
index 578e2b1..2a03ba8 100644
--- a/src/exec.c
+++ b/src/exec.c
@@ -211,7 +211,8 @@
  */
 int osmo_system_nowait2(const char *command, const char **env_whitelist, char **addl_env, const char *user)
 {
-	struct passwd _pw, *pw;
+	struct passwd _pw;
+	struct passwd *pw = NULL;
 	int getpw_buflen = sysconf(_SC_GETPW_R_SIZE_MAX);
 	int rc;
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17884
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idec7041e9ea17a252aefbf6fa90091ae17fd4fcd
Gerrit-Change-Number: 17884
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200512/1b96ba6c/attachment.htm>