This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
ipse gerrit-no-reply at lists.osmocom.orgipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18191 ) Change subject: stats: Rename BSSMAP Rx message counters to match Tx ones. ...................................................................... Patch Set 3: > Patch Set 3: Code-Review-1 > > the renamning of the #defines is without any problem. Remaning the user-visible counter names will break any existing monitoring setup that expects the old names. In general, it might be better to match the names of the new counters to those of the old ones, rather than changing existing iterfaces/naming? > > If we want to go ahead with this (I would appreciate more feedback on this) we have to add an entry to TODO-RELEASE and make sure we mention this very clearly in the next tagged release. The renamed counters were introduced just a couple of patches ago by me, so I doubt anyone except Fairwaves is currently using it, and there is definitely no tagged release with these counters. So I don't think it's worth mentioning in the release notes. The reason for this renaming is a more flexible structure of the stat tags. In essence, we split stat names into a set of tags so we could query a monitoring DB for them. E.g. if you want to see stats for all handover or cipher messages, you can do that now. This idea came to us after we already submitted the original Rx counters patch which is why for those counters I submit this rename as a separate patch. For Tx counters, my patch already follows the new naming convention. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29e42687ac084a60007f0b1ec6ec0a102fb4007f Gerrit-Change-Number: 18191 Gerrit-PatchSet: 3 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 11 May 2020 22:43:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200511/602e33be/attachment.htm>