Change in libosmocore[master]: statsd: fix rendering for groups with idx==0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Earwin @ Fairwaves gerrit-no-reply at lists.osmocom.org
Mon May 11 15:12:51 UTC 2020


Earwin @ Fairwaves has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18173 )

Change subject: statsd: fix rendering for groups with idx==0
......................................................................


Patch Set 1:

> We might want to omit the index for the "global" counter values because there is only one.

I'm considering doing away with 'index' altogether, and introducing a string discriminator value.
That way:
1) you can use things like LAC+CI to identify BTS, instead of configuration-dependent index; something that makes more physical world sense for other repeatable groups (e.g peer identifiers instead of port for MGW RTP stream stats)
2) empty string is a natural sign of "global" counter group, no need to have a separate flag for that


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18173
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id294202fbcebe0b6b155c7f267b2da73af20adf4
Gerrit-Change-Number: 18173
Gerrit-PatchSet: 1
Gerrit-Owner: Earwin @ Fairwaves <earwin at gmail.com>
Gerrit-Reviewer: Earwin @ Fairwaves <earwin at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 11 May 2020 15:12:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200511/8774b9e6/attachment.htm>


More information about the gerrit-log mailing list