Change in pysim[master]: Import function for converting bytes list in (hex or int) to string f...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon May 11 08:22:54 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18195 )

Change subject: Import function for converting bytes list in (hex or int) to string from https://github.com/mitshell/card
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/18195/1/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/18195/1/pySim/utils.py@403 
PS1, Line 403: byteToString
Let's follow similar naming style as the existing functions like b2h(), h2b(). Here is a one-liner that works in both Python versions:

  # List of bytes to string
  def bl2s(bl):
    ''.join([chr(x) for x in bl])


https://gerrit.osmocom.org/c/pysim/+/18195/1/pySim/utils.py@405 
PS1, Line 405: byteToString([116, 101, 115, 116]) -> 'test'
Erlang syntax, nice ;)



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/18195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8c1e39ccf9fb517d465e73f69c720e7fdde02ded
Gerrit-Change-Number: 18195
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 11 May 2020 08:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200511/057b7336/attachment.htm>


More information about the gerrit-log mailing list