Change in osmo-ttcn3-hacks[master]: PCU: introduce a new test case TC_dl_flow_more_blocks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sun May 10 21:51:44 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187 )

Change subject: PCU: introduce a new test case TC_dl_flow_more_blocks
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187/1/pcu/PCU_Tests.ttcn@1644 
PS1, Line 1644: 	ack_nack_desc.receive_block_bitmap[63] := '1'B;
No use of f_acknackdesc_ack_block() here?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187/1/pcu/PCU_Tests.ttcn@1670 
PS1, Line 1670: 			break;
f_acknackdesc_ack_block() ?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187/1/pcu/PCU_Tests.ttcn@1679 
PS1, Line 1679: 	// f_rx_rlcmac_dl_block(dl_block, fn);
a data block? good question.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18187
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45edbc943194c15b084eb04dda390db75b4bfa0f
Gerrit-Change-Number: 18187
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 10 May 2020 21:51:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200510/86f42f36/attachment.htm>


More information about the gerrit-log mailing list