Change in osmo-pcu[master]: fix egprs_mslot_class_from_ra(): multislot class may not be present

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat May 9 13:21:26 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18157 )

Change subject: fix egprs_mslot_class_from_ra(): multislot class may not be present
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/18157/3/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18157/3/src/bts.cpp@679 
PS3, Line 679: 	if (is_11bit && (ra >> 10) == 0x00) /* .0xx xxx. .... */
> I'd love at some point having data strctures and macros to handle all "ra" related stuff... […]
Well, in case of EGPRS Packet Channel Request it makes sense to use the CSN.1 decoder. I already have a patch, just need to find some time to clean it up: https://gerrit.osmocom.org/c/osmo-pcu/+/17718.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18157
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iba0466b29afd26cff317ed4fb6749f8a3079f16a
Gerrit-Change-Number: 18157
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 09 May 2020 13:21:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/904e98e2/attachment.htm>


More information about the gerrit-log mailing list