Change in osmo-pcu[master]: bts: Return uint8_t in egprs_mslot_class_from_ra()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18131 )

Change subject: bts: Return uint8_t in egprs_mslot_class_from_ra()
......................................................................

bts: Return uint8_t in egprs_mslot_class_from_ra()

MultislotClass is 5 bit long, so an uint8_t is enough.
In most places we are already storing multislot class as uint8_t.

Change-Id: I1dcaff9d69379453a0b794e5f36b820f5f78531f
---
M src/bts.cpp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  keith: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved



diff --git a/src/bts.cpp b/src/bts.cpp
index a43613e..6578e06 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -673,7 +673,7 @@
  * can only receive EGPRS mslot class through 11-bit EGPRS PACKET CHANNEL
  * REQUEST.
  */
-static inline uint16_t egprs_mslot_class_from_ra(uint16_t ra, bool is_11bit)
+static inline uint8_t egprs_mslot_class_from_ra(uint16_t ra, bool is_11bit)
 {
 	if (is_11bit)
 		return ((ra & 0x3e0) >> 5) + 1;
@@ -750,7 +750,7 @@
 	int plen;
 	uint8_t usf = 7;
 	uint8_t tsc = 0, ta = qta2ta(qta);
-	uint16_t egprs_ms_class = egprs_mslot_class_from_ra(ra, is_11bit);
+	uint8_t egprs_ms_class = egprs_mslot_class_from_ra(ra, is_11bit);
 	bool failure = false;
 
 	rach_frame();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1dcaff9d69379453a0b794e5f36b820f5f78531f
Gerrit-Change-Number: 18131
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/eb22f60a/attachment.htm>