Change in osmo-bsc[master]: chan_alloc: Don't re-invent trx_is_usable and use existing helper

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat May 9 08:05:22 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18127 )

Change subject: chan_alloc: Don't re-invent trx_is_usable and use existing helper
......................................................................

chan_alloc: Don't re-invent trx_is_usable and use existing helper

Signed-off-by: Sylvain Munaut <tnt at 246tNt.com>
Change-Id: I1ca4a6ac6ec2f4e40c8421f31871d9c9e5ac5de5
---
M src/osmo-bsc/chan_alloc.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c
index 75cea71..27c49cd 100644
--- a/src/osmo-bsc/chan_alloc.c
+++ b/src/osmo-bsc/chan_alloc.c
@@ -46,8 +46,7 @@
 		int i;
 
 		/* skip administratively deactivated tranxsceivers */
-		if (!nm_is_running(&trx->mo.nm_state) ||
-		    !nm_is_running(&trx->bb_transc.mo.nm_state))
+		if (!trx_is_usable(trx))
 			continue;
 
 		for (i = 0; i < ARRAY_SIZE(trx->ts); i++) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18127
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1ca4a6ac6ec2f4e40c8421f31871d9c9e5ac5de5
Gerrit-Change-Number: 18127
Gerrit-PatchSet: 6
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/7970e09f/attachment.htm>


More information about the gerrit-log mailing list