Change in libosmocore[master]: stats: Change timer to timerfd to make it a true interval timer.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sat May 9 00:33:47 UTC 2020


ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18141 )

Change subject: stats: Change timer to timerfd to make it a true interval timer.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c 
File src/stats.c:

https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c@105 
PS1, Line 105: static struct osmo_fd osmo_stats_timer = {.fd=-1};
> = { . […]
Ack


https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c@149 
PS1, Line 149: 	if (!(what & BSC_FD_READ))
> BSC_FD_ is only available for backward compat. Use OSMO_FD_READ instead.
Well, this whole piece is a verbatim copy-paste from osmo-bts-trx.

I'm frankly thinking that all this machinery should be hidden in the Osmocom wrapper since it's completely boilerplate. The expiry counter could then be passed to the callback instead of "what".


https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c@157 
PS1, Line 157: 
> I would also add a print NOTICE if expire_count > 1 (or a counter too if you want).
Makes sense, I'll add.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18141
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I23d8b5157ef8a9833ba16a81d9b28a126f303c30
Gerrit-Change-Number: 18141
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 09 May 2020 00:33:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/98b2b882/attachment.htm>


More information about the gerrit-log mailing list