This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18138 ) Change subject: stats: Support regular stats flush ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/18138/1/include/osmocom/core/stats.h File include/osmocom/core/stats.h: https://gerrit.osmocom.org/c/libosmocore/+/18138/1/include/osmocom/core/stats.h@92 PS1, Line 92: int flush_period_counter; /*!< count sends between forced flushes */ unsigned int https://gerrit.osmocom.org/c/libosmocore/+/18138/1/include/osmocom/core/stats.h@134 PS1, Line 134: int osmo_stats_reporter_set_flush_period(struct osmo_stats_reporter *srep, int period); unsigned int https://gerrit.osmocom.org/c/libosmocore/+/18138/1/src/stats.c File src/stats.c: https://gerrit.osmocom.org/c/libosmocore/+/18138/1/src/stats.c@354 PS1, Line 354: if (period < 0) Not needed if you use an unsigned ;) https://gerrit.osmocom.org/c/libosmocore/+/18138/1/src/vty/stats_vty.c File src/vty/stats_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/18138/1/src/vty/stats_vty.c@255 PS1, Line 255: int period = atoi(argv[0]); no need to check here even if we receive an int since VTY protects us from receiveing something out of range. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I04f1e7bdf0d6f20e4f15571e94191de61c47ddad Gerrit-Change-Number: 18138 Gerrit-PatchSet: 1 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 08 May 2020 21:18:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/a2f4a750/attachment.htm>