Change in osmo-bsc[master]: gsm_data: Update trx_is_usable for ericsson BTS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Fri May 8 13:42:06 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18128 )

Change subject: gsm_data: Update trx_is_usable for ericsson BTS
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18128/2/src/osmo-bsc/gsm_data.c 
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18128/2/src/osmo-bsc/gsm_data.c@1387 
PS2, Line 1387: 		if (!nm_is_running(&trx->mo.nm_state))
> Probably adding a comment here explaining that MO object doesn't exist for ericsson would make sense […]
Note that it's not "putting it back". Before this, it would return "true" always for ericsson, no matter the state of any of the NM objects. the check above is conditionned on "is_ipaccess_bts".



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I34bb808cd21575ff25d36e6df028b140935a008f
Gerrit-Change-Number: 18128
Gerrit-PatchSet: 5
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2020 13:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/ef0e79b1/attachment.htm>


More information about the gerrit-log mailing list