This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18129 ) Change subject: bts: Rename mslot_class_from_ra ...................................................................... Patch Set 2: Code-Review+2 (5 comments) I left some comments, mostly unrelated to this change. https://gerrit.osmocom.org/c/osmo-pcu/+/18129/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/18129/2//COMMIT_MSG@9 PS2, Line 9: Ther This? https://gerrit.osmocom.org/c/osmo-pcu/+/18129/2//COMMIT_MSG@9 PS2, Line 9: os BCD-encoding? ;) https://gerrit.osmocom.org/c/osmo-pcu/+/18129/1/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/18129/1/src/bts.cpp@668 PS1, Line 668: uint16_t BTW, EGPRS Multi-Slot Class is 5 bit long (see table 11.2.5a.5), so we don't really need uint16_t here. https://gerrit.osmocom.org/c/osmo-pcu/+/18129/1/src/bts.cpp@671 PS1, Line 671: return (ra & 0x3e0) >> 5; We should add a FIXME here, because this is only valid for One Phase Access Request. https://gerrit.osmocom.org/c/osmo-pcu/+/18129/1/src/bts.cpp@674 PS1, Line 674: 0 This is a valid value for "multislot class 1". -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Idb51836c8c9dd4e865bf2cb0b0c24155662f2ae8 Gerrit-Change-Number: 18129 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 08 May 2020 13:19:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/badd057b/attachment.htm>