This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tnt gerrit-no-reply at lists.osmocom.orgtnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18119 ) Change subject: om2k: Fix the frequency specifier for TX/RX/TS conf requests ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18119/1/src/osmo-bsc/abis_om2000.c File src/osmo-bsc/abis_om2000.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18119/1/src/osmo-bsc/abis_om2000.c@1288 PS1, Line 1288: /* OM2K_DEI_FREQ_SPEC_RX: Using trx_nr as "RX address" only works for single MCTR case */ > wrong indent Ack https://gerrit.osmocom.org/c/osmo-bsc/+/18119/1/src/osmo-bsc/abis_om2000.c@1307 PS1, Line 1307: /* OM2K_DEI_FREQ_SPEC_TX: Using trx_nr as "TX address" only works for single MCTR case */ > wrong indent well wrong is relative, it's on purpose to indicate the comment refers just to the next line and not the entire block, but fine, I'll change it. https://gerrit.osmocom.org/c/osmo-bsc/+/18119/1/src/osmo-bsc/abis_om2000.c@1310 PS1, Line 1310: msgb_tv_put(msg, OM2K_DEI_FILLING_MARKER, trx->nr != 0); /* Filling enabled for C0 only */ > I think the correct check here should be: […] Mmm, it's definitely required at the moment and other parts of the code use trx->nr checks, but I agress the compare to c0 is probably better, so I'll change it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie39a857543adaa11d1822346d8563ce3718412c8 Gerrit-Change-Number: 18119 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt at 246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-Comment-Date: Fri, 08 May 2020 13:02:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/234dedf0/attachment.htm>