Change in osmocom-bb[master]: l1ctl: preserve TS configuration for HR channels

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu May 7 10:50:04 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18095 )

Change subject: l1ctl: preserve TS configuration for HR channels
......................................................................


Patch Set 1: Code-Review-2

(2 comments)

https://gerrit.osmocom.org/c/osmocom-bb/+/18095/1/src/host/trxcon/l1ctl.c 
File src/host/trxcon/l1ctl.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/18095/1/src/host/trxcon/l1ctl.c@661 
PS1, Line 661: NOTE: When (re)configuring a timeslot for TCH/H
I am sorry, but this is a task-specific (OS#4365) solution, so it would only work for TCH/H, but not for SDCCH/4 or SDCCH/8 where you also have sub-channels. See my comments to your previous change, this may cause regressions. Or, if this does not cause any regressions and all ttcn3-bts-tests would still pass, we can make this behavior default.


https://gerrit.osmocom.org/c/osmocom-bb/+/18095/1/src/host/trxcon/l1ctl.c@677 
PS1, Line 677: ts = l1l->trx->ts_list[tn];
Duplicate line.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18095
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3ac0ae22c40e3cb99c44f1156000c6909f739ad4
Gerrit-Change-Number: 18095
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 May 2020 10:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200507/29295b70/attachment.htm>


More information about the gerrit-log mailing list