Change in osmo-ttcn3-hacks[master]: PCU: fix f_pkt_paging_match_tmsi(): drop copy-pasted line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu May 7 10:06:35 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18096 )

Change subject: PCU: fix f_pkt_paging_match_tmsi(): drop copy-pasted line
......................................................................

PCU: fix f_pkt_paging_match_tmsi(): drop copy-pasted line

Change [1] broke the following test cases:

  - TC_paging_cs_from_sgsn_sign_ptmsi,
  - TC_paging_cs_from_sgsn_ptp.

Let's fix this!

Change-Id: I9ec798e44138570bed726ffcd842448e199c1b54
Fixes: [1] I6a859687d9605cc08c51ff44d946c279b79bedfa
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M pcu/PCU_Tests.ttcn
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 0c61595..32df39e 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1604,7 +1604,6 @@
 
 private function f_pkt_paging_match_tmsi(in PacketPagingReq req, template GsmTmsi tmsi)
 runs on RAW_PCU_Test_CT {
-	var MobileIdentityLV_Paging mi_lv := req.repeated_pageinfo.cs.mobile_identity;
 	if (not match(req.repeated_pageinfo.cs.tmsi, tmsi)) {
 		setverdict(fail, "Mobile Identity (TMSI/P-TMSI) mismatch: ",
 			   "expected: ", tmsi, "got: ", req.repeated_pageinfo.cs.tmsi);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18096
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9ec798e44138570bed726ffcd842448e199c1b54
Gerrit-Change-Number: 18096
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200507/cd5aeaae/attachment.htm>


More information about the gerrit-log mailing list