Change in osmo-bsc[master]: om2k: Don't use slashes in FSM IDs and use dashes instead

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Tue May 5 19:49:49 UTC 2020


tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18061 )


Change subject: om2k: Don't use slashes in FSM IDs and use dashes instead
......................................................................

om2k: Don't use slashes in FSM IDs and use dashes instead

slashes are invalid so we can't use om2k_mo_name() directly, so we just
build it manually with dashes.

Signed-off-by: Sylvain Munaut <tnt at 246tNt.com>
Change-Id: I3cfc19670e6d7bb607d796cabcee5e86a15d1985
---
M src/osmo-bsc/abis_om2000.c
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/61/18061/1

diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c
index b221441..d5eb24a 100644
--- a/src/osmo-bsc/abis_om2000.c
+++ b/src/osmo-bsc/abis_om2000.c
@@ -1880,8 +1880,9 @@
 	struct om2k_mo_fsm_priv *omfp;
 	char idbuf[64];
 
-	snprintf(idbuf, sizeof(idbuf), "%s-%s", parent->id,
-		 om2k_mo_name(&mo->addr));
+	snprintf(idbuf, sizeof(idbuf), "%s-%s-%02x-%02x-%02x", parent->id,
+		 get_value_string(om2k_mo_class_short_vals, mo->addr.class),
+		 mo->addr.bts, mo->addr.assoc_so, mo->addr.inst);
 
 	fi = osmo_fsm_inst_alloc_child_id(&om2k_mo_fsm, parent,
 					  term_event, idbuf);
@@ -2143,7 +2144,7 @@
 	struct om2k_trx_fsm_priv *otfp;
 	char idbuf[32];
 
-	snprintf(idbuf, sizeof(idbuf), "%u/%u", trx->bts->nr, trx->nr);
+	snprintf(idbuf, sizeof(idbuf), "%u-%u", trx->bts->nr, trx->nr);
 
 	fi = osmo_fsm_inst_alloc_child_id(&om2k_trx_fsm, parent, term_event,
 					  idbuf);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18061
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3cfc19670e6d7bb607d796cabcee5e86a15d1985
Gerrit-Change-Number: 18061
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200505/5a1cfa39/attachment.htm>


More information about the gerrit-log mailing list