Change in osmo-ttcn3-hacks[master]: BTS: fix missing GPRS Indicator in SI4 Rest Octets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue May 5 19:30:43 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18028 )

Change subject: BTS: fix missing GPRS Indicator in SI4 Rest Octets
......................................................................

BTS: fix missing GPRS Indicator in SI4 Rest Octets

We do have GPRS Indicator in SI3 Rest Octets, but for some reason
it was absent in SI4 Rest Octets. Let's finally enable it, so we
can extend the existing test cases to check GPRS Indicator in the
Rest Octets of both System Information Type 3 and 4.

Change-Id: Ib55c2673b53b5981e57372f4f8cfb0af32e04132
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
Related: OS#3075
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 3ed3655..4466ad4 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -241,9 +241,8 @@
 private template (value) SI4RestOctets ts_SI4RestOctets_def
 modifies ts_SI4RestOctets := {
 	gprs_ind := {
-		/* FIXME: GPRS Indicator shall be present here too */
-		presence := CSN1_L,
-		ind := omit
+		presence := CSN1_H,
+		ind := ts_GPRSIndicator_def
 	}
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18028
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib55c2673b53b5981e57372f4f8cfb0af32e04132
Gerrit-Change-Number: 18028
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200505/d2531c79/attachment.htm>


More information about the gerrit-log mailing list