Change in osmo-ttcn3-hacks[master]: library: add PADDING attributes to SI3/SI4 Rest Octets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue May 5 19:30:42 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18024 )

Change subject: library: add PADDING attributes to SI3/SI4 Rest Octets
......................................................................

library: add PADDING attributes to SI3/SI4 Rest Octets

Change-Id: Icce6d1e565edc6dce51310364079fc3840a18d45
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M library/GSM_RestOctets.ttcn
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/GSM_RestOctets.ttcn b/library/GSM_RestOctets.ttcn
index da3478a..045d177 100644
--- a/library/GSM_RestOctets.ttcn
+++ b/library/GSM_RestOctets.ttcn
@@ -39,6 +39,10 @@
 	variant (iu_mode_ind) "PRESENCE(gprs_ind.presence = '0'B)"
 	/* SI21 field is only present if 'WHERE' information is not present. */
 	variant (si21_ind) "PRESENCE(sched_where.presence = '0'B)"
+
+	/* The TITAN's RAW encoder generates an octet-aligned octetstring,
+	 * so we should make sure that unused bits contain proper padding. */
+	variant "PADDING(yes), PADDING_PATTERN('00101011'B)"
 };
 
 /* 10.5.2.35 SI 4 Rest Octets (O & S) */
@@ -52,6 +56,10 @@
 } with {
 	variant (s_presence) "CSN.1 L/H"
 	variant (s) "PRESENCE(s_presence = '1'B)"
+
+	/* The TITAN's RAW encoder generates an octet-aligned octetstring,
+	 * so we should make sure that unused bits contain proper padding. */
+	variant "PADDING(yes), PADDING_PATTERN('00101011'B)"
 };
 
 /* Selection Parameters */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icce6d1e565edc6dce51310364079fc3840a18d45
Gerrit-Change-Number: 18024
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200505/3c99b00f/attachment.htm>


More information about the gerrit-log mailing list