Change in osmo-gsm-tester[master]: esme: import smpplib module on first use

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue May 5 16:26:43 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18054 )


Change subject: esme: import smpplib module on first use
......................................................................

esme: import smpplib module on first use

Change-Id: Icc92937fdada9210f788805dbc42b80014e345e8
---
M src/osmo_gsm_tester/obj/esme.py
1 file changed, 7 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/54/18054/1

diff --git a/src/osmo_gsm_tester/obj/esme.py b/src/osmo_gsm_tester/obj/esme.py
index 41ec87f..e23e88c 100644
--- a/src/osmo_gsm_tester/obj/esme.py
+++ b/src/osmo_gsm_tester/obj/esme.py
@@ -17,12 +17,6 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-import smpplib.gsm
-import smpplib.client
-import smpplib.command
-import smpplib.consts
-import smpplib.exceptions
-
 from ..core import log
 from ..core.event_loop import MainLoop
 
@@ -35,9 +29,6 @@
 
 class Esme(log.Origin):
 
-    MSGMODE_TRANSACTION = smpplib.consts.SMPP_MSGMODE_FORWARD
-    MSGMODE_STOREFORWARD = smpplib.consts.SMPP_MSGMODE_STOREFORWARD
-
     def __init__(self, msisdn):
         self.msisdn = msisdn
         # Get last characters of msisdn to stay inside MAX_SYS_ID_LEN. Similar to modulus operator.
@@ -51,6 +42,13 @@
         self.listening = False
         self.references_pending_receipt = []
         self.next_user_message_reference = 1
+        import smpplib.gsm
+        import smpplib.client
+        import smpplib.command
+        import smpplib.consts
+        import smpplib.exceptions
+        self.MSGMODE_TRANSACTION = smpplib.consts.SMPP_MSGMODE_FORWARD
+        self.MSGMODE_STOREFORWARD = smpplib.consts.SMPP_MSGMODE_STOREFORWARD
 
     def __del__(self):
         self.cleanup()

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18054
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Icc92937fdada9210f788805dbc42b80014e345e8
Gerrit-Change-Number: 18054
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200505/3c4a1201/attachment.htm>


More information about the gerrit-log mailing list