Change in osmocom-bb[master]: mobile: traffic req check: support EFR

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue May 5 10:38:05 UTC 2020


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/18021 )

Change subject: mobile: traffic req check: support EFR
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 1: Code-Review-1
> 
> I believe that L1CTL handling code should not be involved in such high level checks, so ideally we should drop this 'if' [1] and move your code to the place, from where l1ctl_tx_traffic_req() is called.
> 
> [1] https://git.osmocom.org/osmocom-bb/commit/?h=fixeria/audio&id=8d093f5e291b847c326e02cbbe660a7ad5fc11e1

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/18021/2/src/host/layer23/src/common/l1ctl.c 
File src/host/layer23/src/common/l1ctl.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/18021/2/src/host/layer23/src/common/l1ctl.c@898 
PS2, Line 898: * FIXME: this is FR only, check for TCH/F (FR) and TCH/H (HR) */
             : 		/* RFC 3551, section 4.5.8 GSM */
             : 		if (frame_len != 13) {
> actually, the code claims to be FR only, but then it actually checks for 13 and not 33. […]
Thanks, fixed and verified that both the FR and EFR code paths are working.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18021
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iba84f5d60ff5b1a2db8fb6af5131e185965df7c9
Gerrit-Change-Number: 18021
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 May 2020 10:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200505/75c3b9f8/attachment.htm>


More information about the gerrit-log mailing list