This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18009 ) Change subject: bts_nokia_site: Fix LAPD segfault during reset procedure ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/18009/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/18009/1/include/osmocom/bsc/gsm_data.h@1144 PS1, Line 1144: bts_reset_timer_cnf, /* timer for BTS RESET */ ugh so this now is 1 bit less? Having no size in this one is really confusing. https://gerrit.osmocom.org/c/osmo-bsc/+/18009/1/src/osmo-bsc/bts_nokia_site.c File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18009/1/src/osmo-bsc/bts_nokia_site.c@1484 PS1, Line 1484: bts->nokia.wait_reset = 0; Can you add an enum field for 0? https://gerrit.osmocom.org/c/osmo-bsc/+/18009/1/src/osmo-bsc/bts_nokia_site.c@1488 PS1, Line 1488: } Then add a case for the enum val 0 and comment it's already being disabled. https://gerrit.osmocom.org/c/osmo-bsc/+/18009/1/src/osmo-bsc/bts_nokia_site.c@1592 PS1, Line 1592: * the middle of processing an LAPD I framd and are subsequently returning framd/frame? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6270c7210f600e53f845561898245d2fd30a368d Gerrit-Change-Number: 18009 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 03 May 2020 14:58:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200503/4f60cc05/attachment.htm>