Change in osmo-ttcn3-hacks[master]: BTS: refactor f_si3_has_gprs_indicator(): use SI3RestOctets

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17996 )

Change subject: BTS: refactor f_si3_has_gprs_indicator(): use SI3RestOctets
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17996/1/bts/BTS_Tests.ttcn 
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17996/1/bts/BTS_Tests.ttcn@4908 
PS1, Line 4908: private function f_si3_has_gprs_indicator(Si3RestOctets ro) return boolean {
> That's really confusing! Si3RestOctets vs SI3RestOctets. […]
ACK. We should either rename the old symbol(s) (to SI3RestOctetsRaw?), or completely drop them as they're basically sub-types of RestOctets with length limitations (we can apply those limitations within the related records).

  type record SystemInformationType3 {
    // ...
    RestOctets    rest_octets
  } with { variant (rest_octets) "FIELDLENGTH(4)" };

What do you think?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17996/1/bts/BTS_Tests.ttcn@4909 
PS1, Line 4909: 	var SI3RestOctets rest := dec_SI3RestOctets(ro);
> I'm wondering whether it makes sense to decode it each time inside the function instead of simply pa […]
I was thinking about this, but for now I just want to get rid of manual bit manipulations and make use of the new records. Given that this function is used in several test cases and we only care about the GPRS indicator for now, I think it's ok to have this function.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17996
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2dc970d3d34a7d70c6845558544259e387f1d6fc
Gerrit-Change-Number: 17996
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 02 May 2020 18:26:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200502/f65f043d/attachment.htm>