This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
ipse gerrit-no-reply at lists.osmocom.orgipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/17997 ) Change subject: amr: Fix OA to BWE conversion for SID frames. ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/include/osmocom/netif/amr.h File include/osmocom/netif/amr.h: https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/include/osmocom/netif/amr.h@96 PS1, Line 96: #define AMR_FT_0_LEN_BITS 95 /* 4.75 */ > I lack some documentation here like for the above. […] Makes sense. Will do this in the next revision https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/src/amr.c File src/amr.c: https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/src/amr.c@44 PS1, Line 44: static size_t amr_ft_to_bytes[AMR_FT_MAX] = { > Since we now have it in bits, we can probably drop this static array and use (amr_ft_to_bits[ft] + 7 […] Don't know. This is two extra operations but probably not so critical. I'm ok both ways. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/17997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9fc5fb92e9bada22a47a82fcfb0925e892e50ced Gerrit-Change-Number: 17997 Gerrit-PatchSet: 2 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 02 May 2020 17:30:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200502/ea6b8f5c/attachment.htm>