Change in libosmo-netif[master]: amr: Fix OA to BWE conversion for SID frames.

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/17997 )

Change subject: amr: Fix OA to BWE conversion for SID frames.
......................................................................


Patch Set 1:

(2 comments)

Tests needs update

https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/include/osmocom/netif/amr.h 
File include/osmocom/netif/amr.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/include/osmocom/netif/amr.h@96 
PS1, Line 96: #define AMR_FT_0_LEN_BITS	95	/* 4.75 */
I lack some documentation here like for the above. IIUC these are the same as the above ones but in bits. So it probably makes sense to redefine the above ones for instance:
#define AMR_FT_0_LEN ((AMR_FT_0_LEN_BITS + 7) / 8)


https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/src/amr.c 
File src/amr.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/17997/1/src/amr.c@44 
PS1, Line 44: static size_t amr_ft_to_bytes[AMR_FT_MAX] = {
Since we now have it in bits, we can probably drop this static array and use (amr_ft_to_bits[ft] + 7)/8.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/17997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9fc5fb92e9bada22a47a82fcfb0925e892e50ced
Gerrit-Change-Number: 17997
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 02 May 2020 16:21:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200502/361bcce5/attachment.htm>