This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 )
Change subject: mobile: loopback voice frames
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/c/osmocom-bb/+/17381/6/src/host/layer23/src/mobile/voice.c
File src/host/layer23/src/mobile/voice.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/17381/6/src/host/layer23/src/mobile/voice.c@44
PS6, Line 44: GSM_TCHF_FRAME
I think this implicitly means FR. Other codecs use other types (GSM_TCHF_FRAME_{HR,EFR}, GSM_TCHH_FRAME, GSM_TCHH_FRAME_AMR).
Either add that code to the current patch, or do it in a separate patch. If it's separate, please document the limitation of this implementation in the commitlog and make a big fat comment here. Better even have an assert or an error printf if the tch_mode is not FR.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17381
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83
Gerrit-Change-Number: 17381
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 01 May 2020 14:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200501/5a845596/attachment.htm>